Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test out of order CommitFinalizedBlock #1052

Closed
1 task
Tracked by #745
hdevalence opened this issue Sep 11, 2020 · 1 comment
Closed
1 task
Tracked by #745

Test out of order CommitFinalizedBlock #1052

hdevalence opened this issue Sep 11, 2020 · 1 comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Sep 11, 2020 •
edited by teor2345
Loading

Updated with fixes to @teor2345's review comments, except for the ones about the commented-out test. If it's OK with others, I'd prefer to merge this in advance of resolving that discussion, since most of the work we want to do next is blocked on this PR, but not on the resolution to that discussion. (I'm still committed to resolving it, I'd just prefer to do it in a near-term followup).

Originally posted by @hdevalence in #1043 (comment)

TODO:

We could implement this test by randomising the block order in the continuous blockchain tests.
@hdevalence hdevalence mentioned this issue Sep 11, 2020
Merged
@yaahc yaahc added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup labels Sep 14, 2020
@yaahc yaahc added this to the Validate transactions. milestone Sep 14, 2020
@teor2345 teor2345 changed the title Follow-up resolution to test changes in #1043 Test out of order CommitFinalizedBlock Dec 17, 2020
@mpguerra mpguerra removed this from the Transaction Validation milestone Jan 5, 2021
@mpguerra mpguerra mentioned this issue Jan 21, 2022
Closed
51 tasks
@teor2345
Copy link
Contributor

This is tested by the full sync tests, and other sync tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hdevalence @mpguerra @yaahc @teor2345