Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle FindBlocks in the Inbound service #1078

Closed
4 tasks
hdevalence opened this issue Sep 20, 2020 · 1 comment · Fixed by #1347
Closed
4 tasks

Handle FindBlocks in the Inbound service #1078

hdevalence opened this issue Sep 20, 2020 · 1 comment · Fixed by #1347
Assignees
@oxarbitrage
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Milestone
First Alpha Release

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Sep 20, 2020 •
edited by teor2345
Loading

Is your feature request related to a problem? Please describe.

The inbound network service should handle FindBlocks requests correctly.

Describe the solution you'd like

  • Compute the intersection between the chain specified in the request and the chain in the state service;
  • Query the state service for up to 500 following hashes;
  • Truncate those hashes at stop, if stop is Some;
  • Return the truncated list of hashes.

Additional context

Part of #889.

Response Size:

  • 500 hashes is zcashd's maximum response size.
  • >= 402 hashes is the most efficient response size for zebrad, see Reduce the size of checkpoints #1204. (zebrad uses 1 hash to verify the tip, and discards 1 hash to work around zcashd bugs.)
@hdevalence hdevalence added E-med A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement labels Sep 20, 2020
@hdevalence hdevalence mentioned this issue Sep 20, 2020
Closed
11 tasks
@teor2345 teor2345 added this to the Sync and Network milestone Sep 29, 2020
@teor2345 teor2345 mentioned this issue Oct 28, 2020
Closed
51 tasks
@oxarbitrage oxarbitrage mentioned this issue Nov 16, 2020
Closed
@oxarbitrage
Copy link
Contributor

Blocked on #1306

@oxarbitrage oxarbitrage added the S-blocked Status: Blocked on other tasks label Nov 16, 2020
@teor2345 teor2345 changed the title Handle FindBlocks in the Inbound service Handle FindBlocks in the Inbound service Nov 17, 2020
@oxarbitrage oxarbitrage mentioned this issue Nov 20, 2020
Merged
1 task
@mpguerra mpguerra removed the S-blocked Status: Blocked on other tasks label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Milestone
First Alpha Release
Development

Successfully merging a pull request may close this issue.

Inbound FindBlocks and FindHeaders oxarbitrage/zebra
4 participants
@hdevalence @mpguerra @teor2345 @oxarbitrage