Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIP-211: Disable Addition of New Value to the Sprout Value Pool #1564

Closed
teor2345 opened this issue Jan 7, 2021 · 0 comments · Fixed by #2399
Closed

ZIP-211: Disable Addition of New Value to the Sprout Value Pool #1564

teor2345 opened this issue Jan 7, 2021 · 0 comments · Fixed by #2399
Assignees
@oxarbitrage
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-4 Canopy Network Upgrade: Canopy specific tasks
Milestone
2021 Sprint 13

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jan 7, 2021 •
edited
Loading

Motivation

The Canopy network upgrade disables addition of new value to the sprout value pool:
https://zips.z.cash/zip-0211

Consensus Rules

From the relevant activation height, the vpub_old field of each JoinSplit description MUST be zero.

https://zips.z.cash/zip-0211#specification

A similar rule exists in:
https://zips.z.cash/protocol/protocol.pdf#joinsplitdesc

Solution

Implement https://zips.z.cash/zip-0211, rejecting attempts to add new value to the sprout value pool in the transaction validator.

Additional context

This is a required validation rule for Canopy and later network upgrades.
@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code NU-4 Canopy Network Upgrade: Canopy specific tasks C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jan 7, 2021
@teor2345 teor2345 changed the title Disable Addition of New Value to the Sprout Value Pool ZIP 211: Disable Addition of New Value to the Sprout Value Pool Jan 7, 2021
@teor2345 teor2345 changed the title ZIP 211: Disable Addition of New Value to the Sprout Value Pool ZIP-211: Disable Addition of New Value to the Sprout Value Pool Jan 7, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 2, 2021
@mpguerra mpguerra mentioned this issue Mar 5, 2021
Closed
@oxarbitrage oxarbitrage self-assigned this Jun 26, 2021
@oxarbitrage oxarbitrage mentioned this issue Jun 27, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-4 Canopy Network Upgrade: Canopy specific tasks
Projects
None yet
Milestone
2021 Sprint 13
Development

Successfully merging a pull request may close this issue.

ZIP-211: Validate Disabling Addition of New Value to the Sprout Value Pool oxarbitrage/zebra
3 participants
@mpguerra @teor2345 @oxarbitrage