We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe.
tower-batch uses a semaphore bound of 1, but tower::Buffer uses the supplied bound: https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L60 https://docs.rs/tower/0.4.4/src/tower/buffer/service.rs.html#86
tower-batch
tower::Buffer
Describe the solution you'd like
We should use the supplied bound for the semaphore, so tower-batch can handle the expected number of concurrent callers.
Describe alternatives you've considered
Do nothing: the code might hang or otherwise be slow.
Additional context
This issue was discovered during the review in #1593. It could be a cause of the hangs in #1435, so it's a high priority.
The text was updated successfully, but these errors were encountered:
oxarbitrage
Successfully merging a pull request may close this issue.
Is your feature request related to a problem? Please describe.
tower-batch
uses a semaphore bound of 1, buttower::Buffer
uses the supplied bound:https://github.com/ZcashFoundation/zebra/blob/main/tower-batch/src/service.rs#L60
https://docs.rs/tower/0.4.4/src/tower/buffer/service.rs.html#86
Describe the solution you'd like
We should use the supplied bound for the semaphore, so
tower-batch
can handle the expected number of concurrent callers.Describe alternatives you've considered
Do nothing: the code might hang or otherwise be slow.
Additional context
This issue was discovered during the review in #1593. It could be a cause of the hangs in #1435, so it's a high priority.
The text was updated successfully, but these errors were encountered: