We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The CandidateSet address books: disconnected, gossiped, and failed, are not disjoint. But the module documentation says they should be.
CandidateSet
disconnected
gossiped
failed
Peers are not removed from the other sets when they are added to the failed set in report_failed. So the sets can not possibly be disjoint.
report_failed
Core changes:
PeerState
MetaAddr
Optional improvements: 4. delete unused code
After these changes, there is only one copy of each peer, and it can only be in one state.
The text was updated successfully, but these errors were encountered:
teor2345
Successfully merging a pull request may close this issue.
Description
The
CandidateSet
address books:disconnected
,gossiped
, andfailed
, are not disjoint. But the module documentation says they should be.Analysis
Peers are not removed from the other sets when they are added to the
failed
set inreport_failed
. So the sets can not possibly be disjoint.Suggested Solution
Core changes:
PeerState
enum field to theMetaAddr
MetaAddr
method, rather than an enum variantdisconnected
,gossiped
, andfailed
peer sets, and replace them with lookups into the single peer setOptional improvements:
4. delete unused code
After these changes, there is only one copy of each peer, and it can only be in one state.
The text was updated successfully, but these errors were encountered: