Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use automatically allocated ports in the zebrad tests #1813

Closed
teor2345 opened this issue Feb 24, 2021 · 1 comment
Closed

Use automatically allocated ports in the zebrad tests #1813

teor2345 opened this issue Feb 24, 2021 · 1 comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-cleanup Category: This is a cleanup I-integration-fail Continuous integration fails, including build and test failures

Comments

@teor2345
Copy link
Contributor

Motivation

The zebrad acceptance tests sometimes fail due to port conflicts

Solution

If these failures continue, we should:

  • ask the OS to allocate a listener port, by configuring port 0
  • read the actual port from zebrad's logs
  • launch the test or conflicting process with that port

We won't be able to read the port for some listeners, because the crates we're using don't expose that information.

Priority

This is a low priority, unless we see further test failures.

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low I-integration-fail Continuous integration fails, including build and test failures labels Feb 24, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 26, 2021
@teor2345
Copy link
Contributor Author

We've done this already, and the rest of the tests need fixed ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-cleanup Category: This is a cleanup I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

No branches or pull requests

2 participants