Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP-244: Implement Non-Malleable transaction ids #2050

Closed
2 tasks
teor2345 opened this issue Apr 21, 2021 · 0 comments · Fixed by #2129
Closed
2 tasks

ZIP-244: Implement Non-Malleable transaction ids #2050

teor2345 opened this issue Apr 21, 2021 · 0 comments · Fixed by #2129
Assignees
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Apr 21, 2021

Is your feature request related to a problem? Please describe.

ZIP-244 defines a new transaction digest algorithm currently planned to be applied from the NU5 network upgrade onward.

ZIP-244 creates non-malleable transaction identifiers that commit to all transaction data except for attestations to transaction validity. (That is, signatures and proofs.)

Describe the solution you'd like

We should implement or integrate this new transaction digest algorithm in Zebra as per:

This will include:

Non-malleable transaction ids

Alternative Implementations

The ECC have implemented a version of this in Rust in the librustzcash library, we should be able to either port some of that code or learn from that code to implement the Zebra version.

@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Apr 21, 2021
@teor2345 teor2345 added this to the 2021 Sprint 9 milestone Apr 21, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants