Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Orchard binding verification key derivation #2102

Closed
dconnolly opened this issue May 4, 2021 · 2 comments · Fixed by #2441
Closed

Implement Orchard binding verification key derivation #2102

dconnolly opened this issue May 4, 2021 · 2 comments · Fixed by #2441
Assignees
@oxarbitrage
Labels
A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 15

Comments

@dconnolly
Copy link
Contributor

dconnolly commented May 4, 2021 •
edited by teor2345
Loading

Similar to ShieldedData for Sapling, we need to derive and validate the Orchard binding verification key.
@dconnolly dconnolly added A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks P-Medium labels May 4, 2021
@dconnolly dconnolly self-assigned this May 4, 2021
@dconnolly dconnolly mentioned this issue May 4, 2021
Closed
53 tasks
@mpguerra mpguerra added the S-needs-triage Status: A bug report needs triage label May 5, 2021
@teor2345
Copy link
Contributor

teor2345 commented May 6, 2021

I think this might be a duplicate of #1979. We have an orchard::ShieldedData and orchard::AuthorizedAction as part of the transaction v5 RFC design, they just haven't been implemented yet.

@teor2345
Copy link
Contributor

teor2345 commented May 6, 2021

I think this might be a duplicate of #1979. We have an orchard::ShieldedData and orchard::AuthorizedAction as part of the transaction v5 RFC design, they just haven't been implemented yet.

Actually I think it might be the description that's the issue here - we don't just need to store the data, we also need to process it.

@dconnolly can you update the description to talk about binding signature verification and AuthorizedAction?

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label May 7, 2021
@mpguerra mpguerra added this to the 2021 Sprint 13 milestone May 13, 2021
@oxarbitrage oxarbitrage mentioned this issue Jul 3, 2021
Merged
3 tasks
@mpguerra mpguerra linked a pull request Jul 5, 2021 that will close this issue
Add orchard binding_verification_key #2441
Merged
3 tasks
@mpguerra mpguerra mentioned this issue Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-rust Area: Updates to Rust code NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 15
Development

Successfully merging a pull request may close this issue.

Add orchard binding_verification_key oxarbitrage/zebra
4 participants
@dconnolly @mpguerra @teor2345 @oxarbitrage