Panic during shutdown in StateService::call(Request::CommitBlock)

[teor2345]

Diagnosis

This error happened during shutdown, the underlying issue is #1678.

2021-05-27 08:20:35.560 DDUT IAM
compute.googleapis.com
v1.compute.instances.delete
projects/143793276228/zones/us-east1-d/instances/zebrad-main-wxh1

Here's the relevant log search (for people who have access):
https://console.cloud.google.com/logs/query;query=resource.type%3D%22gce_instance%22%20timestamp%20%3E%3D%20%222021-05-26T22:20:00Z%22%20timestamp%20%3C%3D%20%222021-05-26T22:21:00Z%22;timeRange=2021-05-26T19:25:07.139Z%2F2021-05-27T02:25:07.139161Z;cursorTimestamp=2021-05-26T22:20:38.237823898Z?project=zealous-zebra

Error

sender is not dropped: RecvError(())

Metadata

key	value
version	1.0.0-alpha.9
Zcash network	Mainnet
git commit	7894cec
target triple	x86_64-unknown-linux-gnu
build profile	release
location	zebra-state/src/service.rs:578:26

SpanTrace

SpanTrace:
   0: zebrad::components::inbound::downloads::download_and_verify
           with hash=0000000002d5fbb995e5662c6c58b054a7953b70596015a6d64e03de750e06ed
             at zebrad/src/components/inbound/downloads.rs:170
   1: zebrad::components::inbound::inbound
             at zebrad/src/components/inbound.rs:226
   2: zebra_network::peer::connection::msg_as_req
           with msg=inv
             at zebra-network/src/peer/connection.rs:797
   3: zebra_network::peer::handshake::
           with peer=Out("8.131.253.129:8233")
             at zebra-network/src/peer/handshake.rs:617
   4: zebrad::application::
           with zebrad="7894cec" net="Main"
             at zebrad/src/application.rs:363

Backtrace

Backtrace:
   0: backtrace::backtrace::trace
   1: backtrace::capture::Backtrace::new

[teor2345]

I think we fixed this using the shutdown atomic.

If it happens again, we can open a new ticket.