Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup MetaAddr after security fixes #2292

Closed
5 of 7 tasks
teor2345 opened this issue Jun 14, 2021 · 3 comments
Closed
5 of 7 tasks

Cleanup MetaAddr after security fixes #2292

teor2345 opened this issue Jun 14, 2021 · 3 comments
Labels
A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup I-slow Problems with performance or responsiveness

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jun 14, 2021

Motivation

After the MetaAddr refactors in PRs #2273, #2275, and #2276, we want to clean up the code a bit.

Solution

These changes should all be made in separate PRs.

Refactoring

DateTime32 and Duration32

Optimisation

Documentation

  • Replace unquoted MetaAddr and quoted `MetaAddr` with rustdoc links to MetaAddr: [`MetaAddr`] using fastmod
    • we might want to try the doc_markdown lint here, but it might have a lot of false positives

TODO: add other tasks here as needed

Alternatives

These changes are optional, but they'll make the code easier to maintain.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low I-slow Problems with performance or responsiveness A-network Area: Network protocol updates or fixes labels Jun 14, 2021
@teor2345 teor2345 added this to the 2021 Sprint 14 milestone Jun 14, 2021
@teor2345
Copy link
Contributor Author

This task doesn't contribute directly to NU5 validation or client work, so I'm removing it from the sprint.

In the meantime we should do these tasks as needed for other work.

@teor2345 teor2345 removed this from the 2021 Sprint 14 milestone Jun 15, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jun 21, 2021
@mpguerra
Copy link
Contributor

@teor2345 or @jvff can one of you please split this up into a number of issues for re-triage?

@teor2345
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup I-slow Problems with performance or responsiveness
Projects
None yet
Development

No branches or pull requests

2 participants