You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
teor2345 opened this issue
Jun 14, 2021
· 3 comments
Labels
A-networkArea: Network protocol updates or fixesA-rustArea: Updates to Rust codeC-cleanupCategory: This is a cleanupI-slowProblems with performance or responsiveness
A-networkArea: Network protocol updates or fixesA-rustArea: Updates to Rust codeC-cleanupCategory: This is a cleanupI-slowProblems with performance or responsiveness
Motivation
After the
MetaAddr
refactors in PRs #2273, #2275, and #2276, we want to clean up the code a bit.Solution
These changes should all be made in separate PRs.
Refactoring
MetaAddrEvent
enum out ofMetaAddrChange
, and turn change into a struct containing an addr and event #3248PeerServices::NODE_NETWORK
#3249DateTime32 and Duration32
Optimisation
AddressBook
returning the next peer by usingmin()
rather thancollect::<BTreeSet>().next()
Copy
types, guided by the following lints:trivially_copy_pass_by_ref
ref_option_ref
large_types_passed_by_value(avoid-breaking-exported-api = false)
Documentation
MetaAddr
and quoted`MetaAddr`
with rustdoc links to MetaAddr:[`MetaAddr`]
usingfastmod
doc_markdown
lint here, but it might have a lot of false positivesTODO: add other tasks here as needed
Alternatives
These changes are optional, but they'll make the code easier to maintain.
The text was updated successfully, but these errors were encountered: