Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Transaction::hash() #2438

Closed
conradoplg opened this issue Jul 2, 2021 · 1 comment
Closed

Rename Transaction::hash() #2438

conradoplg opened this issue Jul 2, 2021 · 1 comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Jul 2, 2021

Motivation

With ZIP-244, the transaction ID is no longer simply the hash of the transaction bytes (though it's still a hash...)
For this reason, it could be better to rename the hash() method to id() or txid() to make this clearer.

It may also be nice to:

  • Rename transaction::Hash too.
  • Refactor txid.rs. Should it be incorporated into Transaction, since it's relatively small? See discussion

Specifications

N/A

Designs

N/A

Related Work

Follow up to #2129

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jul 2, 2021
@mpguerra mpguerra added this to the 2021 Sprint 14 milestone Jul 7, 2021
@teor2345 teor2345 added the P-Low label Jul 8, 2021
@teor2345 teor2345 removed this from the 2021 Sprint 14 milestone Jul 8, 2021
@mpguerra mpguerra added the C-cleanup Category: This is a cleanup label Jul 9, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jul 19, 2021
@conradoplg
Copy link
Collaborator Author

I still would like to this but it's not important nor required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

3 participants