Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Memo an enum type #250

Closed
dconnolly opened this issue Feb 13, 2020 · 5 comments
Closed

Make Memo an enum type #250

dconnolly opened this issue Feb 13, 2020 · 5 comments
Labels
C-design Category: Software design work

Comments

@dconnolly
Copy link
Contributor

As described in
#249 (comment)
#249 (comment)
https://github.com/zcash/librustzcash/pull/177/files
@dconnolly dconnolly added Poll::Ready C-design Category: Software design work labels Feb 13, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone Feb 13, 2020
@dconnolly dconnolly self-assigned this Feb 13, 2020
@hdevalence hdevalence mentioned this issue Feb 13, 2020
Closed
@dconnolly dconnolly assigned yaahc and unassigned dconnolly Jul 2, 2020
@dconnolly
Copy link
Contributor Author

@str4d when we opened this ticket we noticed an incompatibility between the spec and I think ZIP 302 memos, a flag indicating that something is all binary or not, does this ring a bell to you?

@yaahc
Copy link
Contributor

yaahc commented Jul 22, 2020

@dconnolly are you handling this issue as well as part of the note commitment work that you took over or is this issue still in my court?

@dconnolly
Copy link
Contributor Author

I'll grab it as I'm moving that struct/impl around anyway 👍

@dconnolly dconnolly assigned dconnolly and unassigned yaahc Jul 22, 2020
@dconnolly dconnolly removed this from the Validate transactions. milestone Jul 23, 2020
@dconnolly
Copy link
Contributor Author

Related: #242

@dconnolly dconnolly added this to the Wallet Support 💰 milestone Jul 24, 2020
@mpguerra mpguerra removed this from the Wallet Support 💰 milestone Jan 5, 2021
@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
@mpguerra mpguerra mentioned this issue Mar 10, 2021
Closed
13 tasks
@mpguerra mpguerra removed the E-easy label Mar 23, 2021
@dconnolly
Copy link
Contributor Author

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-design Category: Software design work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hdevalence @dconnolly @mpguerra @yaahc