Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test History Tree serialization #2560

Closed
Tracked by #745
conradoplg opened this issue Aug 2, 2021 · 1 comment
Closed
Tracked by #745

Test History Tree serialization #2560

conradoplg opened this issue Aug 2, 2021 · 1 comment
Labels
C-enhancement Category: This is an improvement S-blocked Status: Blocked on other tasks

Comments

@conradoplg
Copy link
Collaborator

Motivation

#2553 adds History Tree serialization in the state using bincode and serde (using a helper HistoryTreeParts struct). However, there is no particular tests for this functionality.

Add tests for it.

See https://github.com/ZcashFoundation/zebra/pull/2553/files#r680669776 for context

Specifications

N/A

Designs

N/A

Related Work

Follow up to #2553

Note that in #2331 we want to remove serde and change the serialization format, which will change the tests.

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 2, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Aug 16, 2021
@mpguerra mpguerra added the S-blocked Status: Blocked on other tasks label Oct 1, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jun 2, 2022

This seems ok for now.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement S-blocked Status: Blocked on other tasks
Projects
None yet
Development

No branches or pull requests

3 participants