Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing references to transaction verification consensus rules #2616

Closed
oxarbitrage opened this issue Aug 12, 2021 · 1 comment
Closed
Labels
A-consensus Area: Consensus rule updates A-docs Area: Documentation S-needs-spec-update Status: Not in the Zcash spec, but it should be

Comments

@oxarbitrage
Copy link
Contributor

In https://github.com/ZcashFoundation/zebra/blob/v1.0.0-alpha.14/zebra-consensus/src/transaction.rs#L435 and https://github.com/ZcashFoundation/zebra/blob/v1.0.0-alpha.14/zebra-consensus/src/transaction.rs#L522 we implement some consensus rules that dont have any reference in the spec.

Will be good to add them when we get the time as it is hard to find them.

Also, for the binding verification key validation in sapling and in orchard there is no comment nor reference to their corresponding rules in the spec.

This is a low priority issue that was found during #2441

@mpguerra mpguerra added A-consensus Area: Consensus rule updates A-docs Area: Documentation P-Low S-needs-spec-update Status: Not in the Zcash spec, but it should be S-needs-triage Status: A bug report needs triage labels Aug 13, 2021
@teor2345 teor2345 changed the title Add missing references to consensus rules Add missing references to transaction verification consensus rules Oct 31, 2021
@oxarbitrage
Copy link
Contributor Author

This was all fixed when we did #3125

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-docs Area: Documentation S-needs-spec-update Status: Not in the Zcash spec, but it should be
Projects
None yet
Development

No branches or pull requests

2 participants