Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject duplicate UTXO spends and nullifier reveals across mempool transactions #2682

Closed
Tracked by #2309
teor2345 opened this issue Aug 26, 2021 · 1 comment · Fixed by #2765
Closed
Tracked by #2309

Reject duplicate UTXO spends and nullifier reveals across mempool transactions #2682

teor2345 opened this issue Aug 26, 2021 · 1 comment · Fixed by #2765
Assignees
@jvff
Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Milestone
2021 Sprint 19

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 26, 2021 •
edited
Loading

Motivation

Mempools typically require a consistent set of transactions, which could all be mined into a single block.

In order to support this restriction, Zebra should reject transactions that:

  • spend outputs that are already spent by existing mempool transactions
  • reveal nullifiers that are already revealed by existing mempool transactions

If we make this change, we should also reject transactions that duplicate spends in recently committed blocks (#2631).
@teor2345 teor2345 added A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Aug 26, 2021
This was referenced Aug 26, 2021
Closed
Merged
@mpguerra mpguerra added this to the 2021 Sprint 18 milestone Sep 7, 2021
@oxarbitrage oxarbitrage mentioned this issue Sep 9, 2021
Closed
@jvff jvff self-assigned this Sep 13, 2021
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @upbqdn

@jvff jvff modified the milestones: 2021 Sprint 19, 2021 Sprint 18 Sep 14, 2021
This was referenced Sep 16, 2021
Merged
Merged
@dconnolly dconnolly mentioned this issue Sep 20, 2021
Closed
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvff jvff

Labels
A-consensus Area: Consensus rule updates A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Milestone
2021 Sprint 19
Development

Successfully merging a pull request may close this issue.

Reject conflicting mempool transactions jvff/zebra
4 participants
@dconnolly @mpguerra @jvff @teor2345