Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zebrad acceptance tests for the mempool #2691

Closed
2 of 4 tasks
Tracked by #2309
teor2345 opened this issue Aug 30, 2021 · 3 comments · Fixed by #2880
Closed
2 of 4 tasks
Tracked by #2309

Add zebrad acceptance tests for the mempool #2691

teor2345 opened this issue Aug 30, 2021 · 3 comments · Fixed by #2880
Assignees

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 30, 2021

Motivation

The mempool unit tests cover a lot of mempool functionality, using MockServices where needed.

But there are some things we can't test unless we actually run zebrad:

  • mempool startup from zebrad's start command
    • the unit tests already check that the mempool starts disabled
  • mempool startup while the rest of zebrad is running (covered by PR Add a debug config that enables the mempool #2862)
  • mempool running while the rest of zebrad is also running
  • The mempool doesn't activate really early (while we're syncing the first few checkpoints)

We've had panics and deadlocks in similar situations before. (Particularly the start command & running everything at the same time.)

So it's important that we run some tests like this.

@mpguerra
Copy link
Contributor

mpguerra commented Sep 1, 2021

@oxarbitrage
Copy link
Contributor

Related: #2690

@mpguerra mpguerra added this to the 2021 Sprint 20 milestone Sep 15, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 20 milestone Oct 4, 2021
@teor2345 teor2345 added this to the 2021 Sprint 20 milestone Oct 12, 2021
@teor2345 teor2345 added P-Medium S-needs-investigation Status: Needs further investigation labels Oct 12, 2021
@mpguerra mpguerra added the S-blocked Status: Blocked on other tasks label Oct 12, 2021
@teor2345 teor2345 removed S-blocked Status: Blocked on other tasks S-needs-investigation Status: Needs further investigation labels Oct 13, 2021
@teor2345
Copy link
Contributor Author

Unblocked by merging PR #2862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants