Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip download and verification if the transaction is already in the mempool or state #2708

Closed
Tracked by #2309
teor2345 opened this issue Aug 30, 2021 · 1 comment · Fixed by #2718
Closed
Tracked by #2309
Assignees

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 30, 2021

Motivation

In the transaction download stream, we want to skip transactions we've already downloaded or verified.

We want to skip:

  • witnessed transaction IDs (WtxId) that are already in the mempool
  • witnessed transaction IDs (WtxId) that have already been rejected by the mempool
  • mined transaction IDs (transaction::Hash) that have already been committed to the state

We need to check:

  • transaction IDs before downloading
  • downloaded and PushTransactions before verifying
@mpguerra
Copy link
Contributor

mpguerra commented Sep 2, 2021

I forgot this one also needs an estimate. Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

Probably just an estimate from @conradoplg is fine since they're the one who has actually worked on it already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants