Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Zebra to Rust 2021 edition #2709

Closed
teor2345 opened this issue Aug 30, 2021 · 1 comment · Fixed by #3332
Closed

Upgrade Zebra to Rust 2021 edition #2709

teor2345 opened this issue Aug 30, 2021 · 1 comment · Fixed by #3332
Assignees
@dconnolly
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 30, 2021 •
edited
Loading

Motivation

Rust will have a new 2021 edition in October:
https://doc.rust-lang.org/edition-guide/rust-2021/index.html

Zebra can stay on the 2018 edition, but we might miss out on new features. And some code will be harder to write.

Tasks

  • run the fix command for 2021 edition changes
  • configure all crates to use the 2021 edition
    • this also upgrades the cargo dependency resolver to version 2
  • ensure compatibility by adding #[deny(clippy::rust-2021-compatibility)] to our clippy config in each crate
@teor2345 teor2345 added A-rust Area: Updates to Rust code A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low labels Aug 30, 2021
@mpguerra mpguerra added this to the 2021 Sprint 19 milestone Sep 1, 2021
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @upbqdn

@mpguerra mpguerra removed this from the 2021 Sprint 20 milestone Sep 27, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Oct 13, 2021
@teor2345 teor2345 mentioned this issue Nov 4, 2021
Merged
3 tasks
@teor2345 teor2345 changed the title Check Zebra for Rust 2021 edition compatibility Upgrade Zebra to Rust 2021 edition Nov 8, 2021
@teor2345 teor2345 removed the A-devops Area: Pipelines, CI/CD and Dockerfiles label Dec 22, 2021
@dconnolly dconnolly mentioned this issue Jan 12, 2022
Merged
1 task
@dconnolly dconnolly self-assigned this Jan 12, 2022
@mergify mergify bot closed this as completed in #3332 Jan 14, 2022
@arya2 arya2 mentioned this issue Mar 31, 2023
Merged
6 tasks
@mpguerra mpguerra mentioned this issue Apr 11, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce Rust edition 2021 ZcashFoundation/zebra
3 participants
@dconnolly @mpguerra @teor2345