Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document service buffer size #2743

Closed
oxarbitrage opened this issue Sep 8, 2021 · 1 comment
Closed

Document service buffer size #2743

oxarbitrage opened this issue Sep 8, 2021 · 1 comment

Comments

@oxarbitrage
Copy link
Contributor

In #2718 we created a new service with a buffer size of 20 (

let mempool = ServiceBuilder::new().buffer(20).service(mempool_service);
) because the state service uses the same size (
let state = ServiceBuilder::new().buffer(20).service(state_service);
).

We are not sure if this is the right thing to do so we should find out why 20 is a good choice and document this in the code.

@teor2345
Copy link
Contributor

teor2345 commented Jun 2, 2022

This seems like it's not that important.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants