Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mempool metrics related to memory usage #2869

Closed
conradoplg opened this issue Oct 13, 2021 · 1 comment
Closed

Add mempool metrics related to memory usage #2869

conradoplg opened this issue Oct 13, 2021 · 1 comment
Labels
C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use

Comments

@conradoplg
Copy link
Collaborator

Motivation

It would be good to have metrics that report the memory usage of the mempool. One of these is zcash.mempool.usage.bytes that zcashd uses.

However, that's a bit tricky to measure. We can use https://github.com/str4d/memuse but we'd still need to implement a trait for every type used by the mempool, or preferably adding a derive macro to that package.

Specifications

Designs

Related Work

This is a follow-up to #2626, and was postponed due to additional work required.

@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Oct 13, 2021
@mpguerra mpguerra added A-infrastructure Area: Infrastructure changes I-usability Zebra is hard to understand or use P-Low and removed A-infrastructure Area: Infrastructure changes labels Nov 23, 2021
@teor2345
Copy link
Contributor

teor2345 commented Jun 2, 2022

We're not planning on adding more metrics soon.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
None yet
Development

No branches or pull requests

3 participants