Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treestate type #290

Closed
dconnolly opened this issue Mar 3, 2020 · 3 comments
Closed

Treestate type #290

dconnolly opened this issue Mar 3, 2020 · 3 comments
Labels
NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) NU-1 Sapling Network Upgrade: Sapling specific tasks

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Mar 3, 2020 •
edited
Loading

Sprout and Sapling use different hashes but we can be generic over that.

image

image

image

https://zips.z.cash/protocol/protocol.pdf#transactions
@hdevalence hdevalence mentioned this issue Mar 3, 2020
Closed
@dconnolly
Copy link
Contributor Author

We may not want to be generic over the treestate type, since there may be different logic between different zcash versions' treestates.

@dconnolly dconnolly self-assigned this May 28, 2020
@dconnolly dconnolly mentioned this issue Jul 9, 2020
Closed
6 tasks
@dconnolly
Copy link
Contributor Author

This may be already resolved with https://github.com/ZcashFoundation/zebra/blob/main/zebra-chain/src/sapling/tree.rs and https://github.com/ZcashFoundation/zebra/blob/main/zebra-chain/src/sprout/tree.rs

@mpguerra mpguerra removed this from the Block Validation milestone Jan 5, 2021
@mpguerra mpguerra added NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) NU-1 Sapling Network Upgrade: Sapling specific tasks labels Jan 15, 2021
@mpguerra mpguerra mentioned this issue Mar 10, 2021
Closed
13 tasks
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@mpguerra
Copy link
Contributor

mpguerra commented Jun 2, 2021

@dconnolly I see we have https://github.com/ZcashFoundation/zebra/blob/main/zebra-chain/src/orchard/tree.rs also. Can we close this issue?

@mpguerra mpguerra added this to the 2021 Sprint 21 milestone Oct 1, 2021
@mpguerra mpguerra removed this from the 2021 Sprint 22 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) NU-1 Sapling Network Upgrade: Sapling specific tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hdevalence @dconnolly @mpguerra