Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default target output path on Windows CI builds #3005

Closed
jvff opened this issue Nov 2, 2021 · 3 comments
Closed

Restore default target output path on Windows CI builds #3005

jvff opened this issue Nov 2, 2021 · 3 comments
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup

Comments

@jvff
Copy link
Contributor

jvff commented Nov 2, 2021

Motivation

When Tokio was upgraded (#2994), the CI Windows builds started failing due to insufficient disk space. As a temporary workaround, the target output directory was changed to use a separate larger drive (C: instead of D:). However, it would be best to not have this workaround, and to just optimize the Zebra build to use less disk space.

Related Work

#2994 introduced the workaround.

@jvff jvff added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Nov 2, 2021
@jvff jvff added this to the 2021 Sprint 23 milestone Nov 2, 2021
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-Low and removed C-enhancement Category: This is an improvement labels Nov 2, 2021
@mpguerra
Copy link
Contributor

mpguerra commented Nov 3, 2021

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Nov 5, 2021
@teor2345
Copy link
Contributor

teor2345 commented Nov 8, 2021

Let's do this after we've resolved most of our duplicate dependencies.
If we do it too soon, the build directory could get big again, and we might have to revert it.

@dconnolly
Copy link
Contributor

Not strictly required for release candidate

@jvff jvff closed this as completed Mar 18, 2022
@mpguerra mpguerra closed this as not planned Won't fix, can't repro, duplicate, stale May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup
Projects
None yet
Development

No branches or pull requests

4 participants