Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose proof validation for BCTV14 type #304

Closed
dconnolly opened this issue Mar 10, 2020 · 1 comment
Closed

Expose proof validation for BCTV14 type #304

dconnolly opened this issue Mar 10, 2020 · 1 comment

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Mar 10, 2020

Expose validation on our Bctv14 type. If we come across a BCTV14 proof during validation, we should panic or error. In the checkpoint verifier, we should be only checking hashes, so if we've gotten to calling down to validating the old-type proof, we've done something wrong.

https://github.com/ZcashFoundation/zebra/blob/main/zebra-chain/src/proofs/bctv14.rs

https://zips.z.cash/protocol/protocol.pdf#concretezk

@dconnolly dconnolly added A-dependencies Area: Dependency file updates Poll::Ready labels Mar 10, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone Mar 10, 2020
@dconnolly dconnolly removed the A-dependencies Area: Dependency file updates label Mar 10, 2020
@hdevalence
Copy link
Contributor

For the reason described here: #305 (comment) I think it doesn't make sense to have this be a method, so I don't think that there's a work item to do here. The proof types are fixed by the transaction version enum, so we can't come across a BCTV14 proof except with an old tx version, and those will have to be rejected for other consensus reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants