Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in/tidy up SIGHASH #306

Closed
dconnolly opened this issue Mar 10, 2020 · 1 comment · Fixed by #870
Closed

Pull in/tidy up SIGHASH #306

dconnolly opened this issue Mar 10, 2020 · 1 comment · Fixed by #870
Assignees
@yaahc
Labels
A-dependencies Area: Dependency file updates
Milestone
Transaction Valid...

Comments

@dconnolly
Copy link
Contributor

dconnolly commented Mar 10, 2020 •
edited
Loading

See sighash.rs in librustzcash.

Basically as a library function that will then be called by a hashing method on Transaction type as needed, if not hashing the entire transaction, as appropriate.

image
https://zips.z.cash/protocol/protocol.pdf#sighash
@dconnolly dconnolly added A-dependencies Area: Dependency file updates Poll::Ready labels Mar 10, 2020
@dconnolly dconnolly added this to the Validate transactions. milestone Mar 10, 2020
@hdevalence hdevalence mentioned this issue Mar 10, 2020
Closed
@dconnolly dconnolly self-assigned this Jul 2, 2020
@yaahc yaahc self-assigned this Aug 7, 2020
@yaahc yaahc mentioned this issue Aug 11, 2020
Merged
@dconnolly dconnolly mentioned this issue Aug 11, 2020
Closed
27 tasks
@dconnolly
Copy link
Contributor Author

PR #870 has done part of this work but it's incomplete

@yaahc yaahc linked a pull request Aug 25, 2020 that will close this issue
Implement sighash #870
Merged
@yaahc yaahc closed this as completed Sep 4, 2020
@dconnolly dconnolly removed their assignment Sep 5, 2020
@dconnolly dconnolly mentioned this issue Mar 5, 2021
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yaahc yaahc

Labels
A-dependencies Area: Dependency file updates
Projects
None yet
Milestone
Transaction Validation
Development

Successfully merging a pull request may close this issue.

Implement sighash ZcashFoundation/zebra
3 participants
@hdevalence @dconnolly @yaahc