Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn the syncer as an async task #3114

Closed
Tracked by #2310
teor2345 opened this issue Nov 29, 2021 · 0 comments · Fixed by #3168
Closed
Tracked by #2310

Spawn the syncer as an async task #3114

teor2345 opened this issue Nov 29, 2021 · 0 comments · Fixed by #3168
Assignees
Labels
C-enhancement Category: This is an improvement I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness I-usability Zebra is hard to understand or use S-needs-investigation Status: Needs further investigation

Comments

@teor2345
Copy link
Contributor

Motivation

Zebra's syncer currently runs in the initial async task on the main thread. This means that it is launched and terminated differently to other tasks.

It also shares the thread with more urgent tasks, such as interrupts and signals. But that should be handled by #1351.

Designs

  • Make the PeerSet service sync and send (needs a Rust expert)
  • Spawn the syncer in a separate task
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage S-needs-investigation Status: Needs further investigation P-Low I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness I-usability Zebra is hard to understand or use labels Nov 29, 2021
@teor2345 teor2345 self-assigned this Jan 6, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement I-hang A Zebra component stops responding to requests I-slow Problems with performance or responsiveness I-usability Zebra is hard to understand or use S-needs-investigation Status: Needs further investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants