Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document consensus rules from Zcash spec: 4.12 Balance (Sprout) #3219

Closed
Tracked by #3125
mpguerra opened this issue Dec 14, 2021 · 1 comment · Fixed by #3286
Closed
Tracked by #3125

Document consensus rules from Zcash spec: 4.12 Balance (Sprout) #3219

mpguerra opened this issue Dec 14, 2021 · 1 comment · Fixed by #3286
Assignees

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Dec 14, 2021

For each consensus rule:

  • check that the rule is implemented in Zebra
  • make sure the latest version of the rule is quoted in the docs for the code that implements it
  • make sure the code implements the latest version of the rule

Consensus rule

https://zips.z.cash/protocol/protocol.pdf#joinsplitbalance
Screenshot 2021-12-16 at 17 26 48

See ZIP 209: Prohibit Negative Shielded Chain Value Pool Balances also

Implementation

@mpguerra mpguerra changed the title Document 4.12 Balance (Sprout) consensus rules Document consensus rules from Zcash spec: 4.12 Balance (Sprout) Dec 16, 2021
@teor2345 teor2345 assigned oxarbitrage and unassigned teor2345 Dec 19, 2021
@teor2345
Copy link
Contributor

It doesn't really make sense for oxarbitrage to do two of the negative value balance rules, and me to do the other one. I'm pretty sure all 3 rules will get documented in exactly the same module. (Maybe even in the same method?)

I'm happy to pick up other tickets though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants