Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build crates independently on Windows MSVC and MinGW #3800

Closed
2 tasks
conradoplg opened this issue Mar 8, 2022 · 2 comments
Closed
2 tasks

CI: build crates independently on Windows MSVC and MinGW #3800

conradoplg opened this issue Mar 8, 2022 · 2 comments
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Mar 8, 2022

Motivation

We disabled Windows build in #3799 due to zcash_script requiring MinGW, and rocksdb requiring rocksdb.

But we could build and test crates independently, with different targets. With that, we at least would have some testing on Windows

Specifications

Designs

  • Re-enable Windows build

  • Change CI to build and test (on Windows):

  • zebra_script with MinGW

  • zebra_state with MSVC

  • Any crates that import only one of these two with the matching compiler

  • Any crates that import neither with both

  • Skip any crates that import both

Related Work

@conradoplg conradoplg added A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Low ❄️ labels Mar 8, 2022
@teor2345 teor2345 changed the title CI: build crates independently on Windows CI: build crates independently on Windows MSVC and MinGW Mar 9, 2022
@ftm1000
Copy link

ftm1000 commented Mar 10, 2022

@teor2345
Copy link
Contributor

We'll probably just fix the Windows build.

@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

5 participants