Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated zcash_proofs #3831

Closed
Tracked by #3096
conradoplg opened this issue Mar 10, 2022 · 1 comment · Fixed by #5481 or #5505
Closed
Tracked by #3096

Remove duplicated zcash_proofs #3831

conradoplg opened this issue Mar 10, 2022 · 1 comment · Fixed by #5481 or #5505
Assignees
@upbqdn
Labels
C-enhancement Category: This is an improvement

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Mar 10, 2022 •
edited by teor2345
Loading

Motivation

We forked zcash_proofs because we need Sprout downloading support zcash/librustzcash#459, which causes it to be duplicated as a dependency since other crates we use also import the upstream version.

Specifications

Designs

After the PR is merged upstream:

  • Remove reference to the fork
  • Remove the exceptions from deny.toml

Related Work
@conradoplg conradoplg added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Mar 10, 2022
@conradoplg conradoplg mentioned this issue Mar 10, 2022
Merged
3 tasks
@conradoplg conradoplg added the S-blocked Status: Blocked on other tasks label Apr 8, 2022
@teor2345 teor2345 mentioned this issue Aug 25, 2022
Closed
76 tasks
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
This was referenced Oct 19, 2022
Merged
Closed
@mpguerra mpguerra added P-High 🔥 and removed S-blocked Status: Blocked on other tasks labels Oct 21, 2022
@teor2345 teor2345 mentioned this issue Oct 24, 2022
Closed
@mpguerra
Copy link
Contributor

removing from sprint as it seems like doing #5445 will fix this

@upbqdn upbqdn mentioned this issue Oct 25, 2022
Merged
5 tasks
@upbqdn upbqdn self-assigned this Oct 26, 2022
@mergify mergify bot closed this as completed in #5481 Oct 28, 2022
Repository owner moved this from 🆕 New to ✅ Done in Zebra Oct 28, 2022
@teor2345 teor2345 mentioned this issue Oct 30, 2022
Merged
5 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upbqdn upbqdn

Labels
C-enhancement Category: This is an improvement
Projects
Zebra
Archived in project
Milestone
No milestone
3 participants
@conradoplg @mpguerra @upbqdn