Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zebrad config > zebrad.toml when zebrad.toml doesn't already exist #399

Closed
yaahc opened this issue May 27, 2020 · 1 comment · Fixed by #432
Closed

fix zebrad config > zebrad.toml when zebrad.toml doesn't already exist #399

yaahc opened this issue May 27, 2020 · 1 comment · Fixed by #432
Labels
C-bug Category: This is a bug E-help-wanted Call for participation: Help is requested to fix this issue. good first issue

Comments

@yaahc
Copy link
Contributor

yaahc commented May 27, 2020

zebrad is currently setup so that it can run without a config, but if the config is exists there are required fields. This causes issues when trying to create a config file. Running cargo run -- config > zebrad.config in zebra/zebrad causes the OS to immediately create an empty file to store the output of the command, but the output happens after the application attempts to load the config file. This causes the application to immediately exit with an error because it is unable to parse the empty file as a config file.

To fix this we should make the behavior consistent whether or not you have a config file. An empty config file should result in the same behavior as an absent one, which means we want to make whatever fields it requires when a config exists optional.

@teor2345
Copy link
Contributor

teor2345 commented Jun 3, 2020

Should this issue be tagged "open to contributors" ?

@yaahc yaahc added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jun 3, 2020
@yaahc yaahc closed this as completed in #432 Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug E-help-wanted Call for participation: Help is requested to fix this issue. good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants