Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the send transactions test to the main branch #5426

Closed
teor2345 opened this issue Oct 19, 2022 · 3 comments · Fixed by #5480
Closed

Move the send transactions test to the main branch #5426

teor2345 opened this issue Oct 19, 2022 · 3 comments · Fixed by #5480
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-testing Category: These are tests I-cost Zebra infrastructure costs I-slow Problems with performance or responsiveness

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 19, 2022

Motivation

The send transactions test is very slow and copies a lot of data.

We want to fix this test in #5015. But until then, we want to move it to the main branch.

If we move it to the main branch, we'll have a better chance of catching any changes that break this RPC.

Designs

Move the workflow to main like we did in PR #5393.

Rejected Alternatives

If we turn this test off, we need to either:

  • test it manually before every release, or
  • accept the risk that it might be broken in a release.

We're not planning on making any changes to this RPC, but we are working on some related RPC and mempool code that it calls.

Move the job definition into a separate workflow file, and turn off that workflow in GitHub Actions.

@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Oct 19, 2022
@teor2345
Copy link
Contributor Author

@mpguerra this is the slow test we talked about this morning

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ I-slow Problems with performance or responsiveness C-testing Category: These are tests I-cost Zebra infrastructure costs labels Oct 19, 2022
@mpguerra
Copy link
Contributor

Let's move to main for now and see how it goes

@mpguerra
Copy link
Contributor

@teor2345 teor2345 changed the title Move the send transactions test to the main branch or turn it off Move the send transactions test to the main branch Oct 19, 2022
@arya2 arya2 removed the S-needs-triage Status: A bug report needs triage label Oct 25, 2022
@mergify mergify bot closed this as completed in #5480 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement C-testing Category: These are tests I-cost Zebra infrastructure costs I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants