Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add submitblock test to CI #5527

Closed
Tracked by #5234
arya2 opened this issue Nov 1, 2022 · 2 comments · Fixed by #5589
Closed
Tracked by #5234

Add submitblock test to CI #5527

arya2 opened this issue Nov 1, 2022 · 2 comments · Fixed by #5589
Assignees
@arya2
Labels
C-enhancement Category: This is an improvement

Comments

@arya2
Copy link
Contributor

arya2 commented Nov 1, 2022

Motivation

The acceptance test for submit block in #5526 uses the cached zebra state and is ignored in the regular coverage CI.

Add a CI job like the one for the send transaction test for the submit block RPC method.
@arya2 arya2 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Nov 1, 2022
@arya2 arya2 mentioned this issue Nov 1, 2022
Merged
5 tasks
@arya2 arya2 self-assigned this Nov 1, 2022
@arya2 arya2 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
@arya2
Copy link
Contributor Author

arya2 commented Nov 2, 2022

I'll try updating the acceptance test first and re-open this if it's still needed.

@arya2 arya2 reopened this Nov 3, 2022
@mpguerra mpguerra mentioned this issue Nov 3, 2022
Closed
34 tasks
@mpguerra
Copy link
Contributor

mpguerra commented Nov 8, 2022

Hey team! Please add your planning poker estimate with Zenhub @arya2 @dconnolly @gustavovalverde @oxarbitrage @teor2345

@arya2 arya2 mentioned this issue Nov 8, 2022
Merged
5 tasks
@mergify mergify bot closed this as completed in #5589 Nov 10, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arya2 arya2

Labels
C-enhancement Category: This is an improvement
Projects
None yet
Milestone
No milestone
2 participants
@mpguerra @arya2