Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an acceptance test for the getblocktemplate method #5652

Closed
arya2 opened this issue Nov 17, 2022 · 4 comments · Fixed by #5653 or #5761
Closed

Add an acceptance test for the getblocktemplate method #5652

arya2 opened this issue Nov 17, 2022 · 4 comments · Fixed by #5653 or #5761
Assignees
@teor2345
Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@arya2
Copy link
Contributor

arya2 commented Nov 17, 2022

Motivation

The vector and snapshot tests for the getblocktemplate RPC method won't be able to use the non-finalized state to test the contextual validity checks for #5630.

Designs

  • Use from_script_hash(Mainnet, [0x7e; 20]) as the miner_address in the config
  • Sync Zebra to the network tip
  • Call the getblocktemplate RPC method
  • Assert that the call was successful
@arya2 arya2 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium ⚡ A-rpc Area: Remote Procedure Call interfaces labels Nov 17, 2022
@arya2 arya2 self-assigned this Nov 17, 2022
This was referenced Nov 17, 2022
Closed
Merged
@mergify mergify bot closed this as completed in #5653 Nov 18, 2022
@teor2345
Copy link
Contributor

Re-opening this ticket, because the test PR was reverted due to intermittent CI failures.

@teor2345 teor2345 reopened this Nov 21, 2022
This was referenced Nov 21, 2022
Closed
Merged
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345

@teor2345
Copy link
Contributor

So I think this just needs a quick fix to remove an assertion, or fix a bug.

Did you want an estimate for the whole ticket, or just that fix?

@teor2345 teor2345 mentioned this issue Nov 27, 2022
Merged
5 tasks
@teor2345 teor2345 self-assigned this Nov 28, 2022
@teor2345
Copy link
Contributor

teor2345 commented Dec 1, 2022

Hey @arya2 I think the errors in your PR were from code I wrote, so I'm going to try to fix them.

@teor2345 teor2345 mentioned this issue Dec 1, 2022
Merged
5 tasks
@mergify mergify bot closed this as completed in #5761 Dec 1, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Dec 2, 2022
@mpguerra mpguerra added this to Zebra Jan 24, 2023
@mpguerra mpguerra moved this to ✅ Done in Zebra Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
Zebra
Status: Done
Milestone
No milestone
3 participants
@mpguerra @arya2 @teor2345