Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zebrad work with a small number of peers #704

Closed
2 tasks
Tracked by #745
teor2345 opened this issue Jul 21, 2020 · 3 comments
Closed
2 tasks
Tracked by #745

Make zebrad work with a small number of peers #704

teor2345 opened this issue Jul 21, 2020 · 3 comments
Labels
C-bug Category: This is a bug S-blocked Status: Blocked on other tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jul 21, 2020

TODO

Motivation

I tried configuring zebrad with 2 peers today, and no DNS seeders. It just seemed to hang.

But it seemed to work well with the DNS seeders, and a smaller configured peer set limit (around 5).

I don't think fixing this issue is a high priority right now. But we might need to fix it for network integration testing.

We might also need to fix it for wallet or exchange support, so users can connect to a single trusted external node.

@teor2345 teor2345 added C-bug Category: This is a bug Poll::Pending labels Jul 21, 2020
@hdevalence
Copy link
Contributor

This seems like a bug, ideally it would continue to work, although there may be some long delays in request processing at times. For instance, when crawling the network we send two requests for peers to the network, hoping these will be randomly distributed over the network, but Zcashd behaves badly and silently ignores any requests for peers after the first one, so we have to wait for the request to time out. IMO this sort of thing is not worth fixing properly (since it would mean writing a bunch of special-purpose code to work around bad Zcashd behavior that we can just ignore in the common case) but the impact should be limited to delays rather than hangs.

Let's dig into this after we get chain verification working.

@teor2345
Copy link
Contributor Author

teor2345 commented Apr 6, 2021

#1950 might fix this issue, but we need to re-test.

@teor2345
Copy link
Contributor Author

This isn't a supported mode of operation for Zebra, but we do support the 4-8 peers on testnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug S-blocked Status: Blocked on other tasks
Projects
None yet
Development

No branches or pull requests

3 participants