Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate rewriting checkpoint/tests.rs tests in zebra-consensus to use zebra_test::Transcript #744

Closed
Tracked by #745
yaahc opened this issue Jul 23, 2020 · 1 comment
Closed
Tracked by #745

Investigate rewriting checkpoint/tests.rs tests in zebra-consensus to use zebra_test::Transcript #744

yaahc opened this issue Jul 23, 2020 · 1 comment
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-testing Category: These are tests E-help-wanted Call for participation: Help is requested to fix this issue.

Comments

@yaahc
Copy link
Contributor

yaahc commented Jul 23, 2020

Wondering if this could be expressed as a zebra_test::Transcript

It seems like the only thing that's missing is some sort of customizable callback to do additional assertions after each request. I think we might be able to bring in the assertions as an additional service wrapping the transcript.

Originally posted by @yaahc in #736 (comment)
@oxarbitrage oxarbitrage mentioned this issue Jul 27, 2020
Merged
@yaahc yaahc added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement E-help-wanted Call for participation: Help is requested to fix this issue. E-med labels Jul 31, 2020
@teor2345 teor2345 added this to the Block Validation milestone Sep 29, 2020
@mpguerra mpguerra removed this from the Block Validation milestone Jan 5, 2021
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@mpguerra mpguerra added the C-cleanup Category: This is a cleanup label Nov 23, 2021
@mpguerra mpguerra mentioned this issue Jan 21, 2022
Closed
51 tasks
@teor2345 teor2345 added C-testing Category: These are tests S-incomplete and removed C-enhancement Category: This is an improvement labels Feb 22, 2022
@teor2345
Copy link
Contributor

We're unlikely to update these tests any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-testing Category: These are tests E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpguerra @yaahc @teor2345