Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new branch protection rules for Docker config tests #7793

Closed
4 tasks done
mpguerra opened this issue Oct 20, 2023 · 3 comments
Closed
4 tasks done

Add new branch protection rules for Docker config tests #7793

mpguerra opened this issue Oct 20, 2023 · 3 comments
Assignees
@gustavovalverde
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup I-integration-fail Continuous integration fails, including build and test failures

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Oct 20, 2023 •
edited by gustavovalverde
Loading

We need 4 new branch protection rules now that #7616 has merged:

  • Test CD default Docker config file / Test default-conf in Docker
  • Test CD custom Docker config file / Test custom-conf in Docker
  • Test CI default Docker config file / Test default-conf in Docker
  • Test CI custom Docker config file / Test custom-conf in Docker

Originally posted by @teor2345 in #7616 (comment)
@mpguerra mpguerra added this to Zebra Oct 20, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Oct 20, 2023
@mpguerra mpguerra added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures labels Oct 20, 2023
@mpguerra
Copy link
Contributor Author

Can we have someone other than @gustavovalverde or @teor2345 take this one so we spread knowledge on this around the team?
There's documentation on this in #7773

@upbqdn
Copy link
Member

upbqdn commented Oct 20, 2023

I tried adding the rules, but I can't see the "Branches" section in the settings. I guess I don't have the permissions.

@teor2345 teor2345 changed the title Add new branch protection rules Add new branch protection rules for Docker config tests Oct 22, 2023
@gustavovalverde
Copy link
Member

As I was reassigned to this, I've recently added these rules.

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup I-integration-fail Continuous integration fails, including build and test failures
Projects
Zebra
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpguerra @upbqdn @gustavovalverde