Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write scanning results to database #8021

Closed
Tracked by #7728
oxarbitrage opened this issue Nov 28, 2023 · 2 comments · Fixed by #8040
Closed
Tracked by #7728

Write scanning results to database #8021

oxarbitrage opened this issue Nov 28, 2023 · 2 comments · Fixed by #8040
Assignees
@teor2345 @oxarbitrage
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-enhancement Category: This is an improvement

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Nov 28, 2023 •
edited by teor2345
Loading

After we have a database created in #8019 and we have results from #8018, we need to insert them to the database.

This will be the issue that makes the connection between the scanning results and the persistent storage. Results can be written using the Storage::add_sapling_result() method.

Writing results to database files can block, so it should be wrapped in a spawn_blocking() function.
@oxarbitrage oxarbitrage added S-blocked Status: Blocked on other tasks P-Medium ⚡ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Nov 28, 2023
@mpguerra mpguerra added this to Zebra Nov 28, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Nov 28, 2023
@oxarbitrage oxarbitrage mentioned this issue Nov 28, 2023
Closed
@teor2345 teor2345 mentioned this issue Nov 30, 2023
Merged
9 tasks
@teor2345
Copy link
Contributor

I updated this ticket with the functions from PR #8036.

@teor2345 teor2345 self-assigned this Nov 30, 2023
@teor2345 teor2345 added C-enhancement Category: This is an improvement and removed S-blocked Status: Blocked on other tasks labels Nov 30, 2023
@teor2345 teor2345 mentioned this issue Dec 1, 2023
Merged
9 tasks
@mpguerra
Copy link
Contributor

mpguerra commented Dec 1, 2023

@teor2345 can you please add an estimate here?

@mergify mergify bot closed this as completed in #8040 Dec 3, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-enhancement Category: This is an improvement
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scan blocks with sapling keys and write the results to the database ZcashFoundation/zebra
3 participants
@mpguerra @teor2345 @oxarbitrage