Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store scanned TXIDs in display order #8056

Closed
Tracked by #8050
upbqdn opened this issue Dec 5, 2023 · 0 comments · Fixed by #8057
Closed
Tracked by #8050

Store scanned TXIDs in display order #8056

upbqdn opened this issue Dec 5, 2023 · 0 comments · Fixed by #8057
Assignees
@upbqdn
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-rust Area: Updates to Rust code A-state Area: State / database changes C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use

Comments

@upbqdn
Copy link
Member

upbqdn commented Dec 5, 2023 •
edited
Loading

The transaction IDs should be stored in "display order", which is big-endian byte order following the u256 set by Bitcoin and zcashd. Zebra and zcashd also display TXIDs to users in this format.
@upbqdn upbqdn mentioned this issue Dec 5, 2023
Closed
2 tasks
@mpguerra mpguerra added this to Zebra Dec 5, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Dec 5, 2023
@upbqdn upbqdn self-assigned this Dec 5, 2023
@upbqdn upbqdn changed the title the transaction IDs should be stored in "display order" (the same order as zcashd and Zebra display them to users) Store scanned TXIDs in display order Dec 5, 2023
@upbqdn upbqdn added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement P-Medium ⚡ I-usability Zebra is hard to understand or use A-state Area: State / database changes A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 5, 2023
@upbqdn upbqdn mentioned this issue Dec 5, 2023
Merged
7 tasks
@mergify mergify bot closed this as completed in #8057 Dec 5, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upbqdn upbqdn

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-rust Area: Updates to Rust code A-state Area: State / database changes C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(scan): Store scanned TXIDs in "display order" ZcashFoundation/zebra
1 participant
@upbqdn