Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a debug_disable_pow_check field to Network #8362

Closed
Tracked by #7845
arya2 opened this issue Mar 19, 2024 · 2 comments · Fixed by #8421
Closed
Tracked by #7845

Add a debug_disable_pow_check field to Network #8362

arya2 opened this issue Mar 19, 2024 · 2 comments · Fixed by #8421
Assignees
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-feature Category: New features C-testing Category: These are tests

Comments

@arya2
Copy link
Contributor

arya2 commented Mar 19, 2024

Motivation

We want to use this field to disable the equihash and target difficulty checks when validating blocks for Regtest.

@github-project-automation github-project-automation bot moved this to New in Zebra Mar 19, 2024
@arya2 arya2 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests C-feature Category: New features and removed I-usability Zebra is hard to understand or use labels Mar 19, 2024
@mpguerra mpguerra added this to the Regtest Network support milestone Mar 21, 2024
@arya2 arya2 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Mar 26, 2024
@arya2
Copy link
Contributor Author

arya2 commented Mar 26, 2024

We want to use the Regtest PoW parameters instead to preserve test coverage of consensus rules on Regtest.

The equihash parameters for Regtest are different from and easier than those on Mainnet/Testnet. We could add these parameters and the target difficulty limit as fields on NetworkParameters.

We may need to make changes to the internal-miner in Zebra and to the equihash solver in librustzcash to use the different parameters for Regtest. The equihash parameters we need should be in chainparams.cpp.

@arya2
Copy link
Contributor Author

arya2 commented Apr 17, 2024

No harm in adding this alongside the Regtest equihash parameters or to be used until the internal miner is restored.

@arya2 arya2 reopened this Apr 17, 2024
@mpguerra mpguerra moved this from Done to Sprint Backlog in Zebra Apr 17, 2024
@mpguerra mpguerra moved this from Sprint Backlog to Review/QA in Zebra Apr 22, 2024
@arya2 arya2 self-assigned this Apr 22, 2024
@mergify mergify bot closed this as completed in #8421 Apr 26, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Apr 26, 2024
@mpguerra mpguerra removed the NU-6 Network Upgrade: NU6 specific tasks label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-feature Category: New features C-testing Category: These are tests
Projects
Archived in project
2 participants