Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol version information to fields on NetworkParameters #8367

Open
Tracked by #7845
arya2 opened this issue Mar 20, 2024 · 2 comments · Fixed by #8718
Open
Tracked by #7845

Add protocol version information to fields on NetworkParameters #8367

arya2 opened this issue Mar 20, 2024 · 2 comments · Fixed by #8718

Comments

@arya2
Copy link
Contributor

arya2 commented Mar 20, 2024 •
edited
Loading

Motivation

We want to make these values configurable on Testnets:

See #7924 (comment).

Outdated: These have already been added.

Possible Design

Move these values to fields/methods on NetworkParameters.
@arya2 arya2 mentioned this issue Mar 20, 2024
Closed
14 tasks
@github-project-automation github-project-automation bot moved this to New in Zebra Mar 20, 2024
@arya2 arya2 changed the title Move lazy_static constants to fields on NetworkParameters Move lazy_static constants to fields on NetworkParameters Mar 20, 2024
@mpguerra mpguerra added this to the Regtest Network support milestone Mar 22, 2024
@arya2 arya2 self-assigned this May 1, 2024
@arya2 arya2 moved this from New to Sprint Backlog in Zebra May 1, 2024
@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in Zebra May 16, 2024
@arya2
Copy link
Contributor Author

arya2 commented Jul 8, 2024

This isn't a priority right now

@arya2 arya2 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Product Backlog to Done in Zebra Jul 8, 2024
@arya2 arya2 reopened this Jul 22, 2024
@arya2 arya2 moved this from Done to In progress in Zebra Jul 22, 2024
This was referenced Jul 23, 2024
Closed
Merged
@arya2 arya2 changed the title Move lazy_static constants to fields on NetworkParameters Move lazy_static funding stream constants to fields on NetworkParameters Jul 24, 2024
@mpguerra mpguerra moved this from In progress to Review/QA in Zebra Jul 24, 2024
@mergify mergify bot closed this as completed in #8718 Jul 29, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Jul 29, 2024
@arya2
Copy link
Contributor Author

arya2 commented Aug 22, 2024

We still want to move INITIAL_MIN_NETWORK_PROTOCOL_VERSION to a field on testnet::Parameters.

@arya2 arya2 reopened this Aug 22, 2024
@arya2 arya2 removed their assignment Sep 19, 2024
@arya2 arya2 changed the title Move lazy_static funding stream constants to fields on NetworkParameters Add protocol version information to fields on NetworkParameters Sep 19, 2024
@mpguerra mpguerra removed this from the Regtest Network support milestone Oct 18, 2024
@mpguerra mpguerra moved this from Done to Product Backlog in Zebra Oct 18, 2024
@mpguerra mpguerra removed this from the Zebra Ready for zcashd Deprecation milestone Jan 23, 2025
@arya2 arya2 mentioned this issue Jan 29, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Zebra
Status: Product Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(network-params): Configurable Testnet funding streams ZcashFoundation/zebra
2 participants
@mpguerra @arya2