Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(scan): Move integration tests for scanner out of zebrad #8593

Closed
Tracked by #7728
upbqdn opened this issue Jun 6, 2024 · 0 comments · Fixed by #8659
Closed
Tracked by #7728

change(scan): Move integration tests for scanner out of zebrad #8593

upbqdn opened this issue Jun 6, 2024 · 0 comments · Fixed by #8659
Assignees
@oxarbitrage
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests rust Pull requests that update Rust code

Comments

@upbqdn
Copy link
Member

upbqdn commented Jun 6, 2024 •
edited
Loading

The zebrad crate contains a scanner integration test: https://github.com/zcashfoundation/zebra/blob/ce875f512b537d1404b64a8860815b146fe2096e/zebrad/tests/acceptance.rs#L3107.

Suggested Solution

  • Move the test to the new binary once we have it.

Follow-ups

#8585
@github-project-automation github-project-automation bot moved this to New in Zebra Jun 6, 2024
@upbqdn upbqdn added C-testing Category: These are tests A-blockchain-scanner Area: Blockchain scanner of shielded transactions rust Pull requests that update Rust code labels Jun 6, 2024
This was referenced Jun 6, 2024
Merged
Closed
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Jun 7, 2024
@mpguerra mpguerra changed the title change(scan): Move integration tests out of zebrad change(scan): Move integration tests for scanner out of zebrad Jun 20, 2024
@mpguerra mpguerra mentioned this issue Jun 20, 2024
Open
@mpguerra mpguerra mentioned this issue Jul 1, 2024
Merged
7 tasks
@mpguerra mpguerra linked a pull request Jul 1, 2024 that will close this issue
tests(scanner): Move zebra scanner tests to binary #8659
Merged
7 tasks
@mpguerra mpguerra moved this from Sprint Backlog to In progress in Zebra Jul 1, 2024
@mpguerra mpguerra moved this from In progress to Review/QA in Zebra Jul 1, 2024
@mpguerra mpguerra moved this from Review/QA to In progress in Zebra Jul 11, 2024
@mergify mergify bot closed this as completed in #8659 Jul 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Zebra Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-testing Category: These are tests rust Pull requests that update Rust code
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests(scanner): Move zebra scanner tests to binary ZcashFoundation/zebra
2 participants
@upbqdn @oxarbitrage