Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some missing fields to getmininginfo RPC method #8858

Closed
Tracked by #8781
oxarbitrage opened this issue Sep 9, 2024 · 0 comments · Fixed by #8860
Closed
Tracked by #8781

Add some missing fields to getmininginfo RPC method #8858

oxarbitrage opened this issue Sep 9, 2024 · 0 comments · Fixed by #8860
Assignees
@oxarbitrage
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests
Milestone
Zebra can replace...

Comments

@oxarbitrage
Copy link
Contributor

When we implemented getmininginfo only a subset of the fields were included in the response. However in the context of #8781, we might want to add some more, specifically:

These fields could be optional, but I’m using this test to validate the functionality of the framework with Zebra. Adding these fields should not cause any issues and will increase the coverage of our RPC responses for users.
@oxarbitrage oxarbitrage added C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Sep 9, 2024
@github-project-automation github-project-automation bot moved this to New in Zebra Sep 9, 2024
@oxarbitrage oxarbitrage self-assigned this Sep 9, 2024
@mpguerra mpguerra added this to the Zebra can replace `zcashd` milestone Sep 10, 2024
@oxarbitrage oxarbitrage mentioned this issue Sep 10, 2024
Merged
7 tasks
@mergify mergify bot closed this as completed in #8860 Sep 18, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Sep 18, 2024
@mpguerra mpguerra mentioned this issue Sep 18, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests
Projects
Zebra
Archived in project
Milestone
Zebra can replace `zcashd`
Development

Successfully merging a pull request may close this issue.

feat(rpc): Add more fields to getmininginfo call ZcashFoundation/zebra
2 participants
@mpguerra @oxarbitrage