Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite block::tests::generate as proptest strategies. #919

Closed
Tracked by #745
hdevalence opened this issue Aug 18, 2020 · 1 comment
Closed
Tracked by #745

Rewrite block::tests::generate as proptest strategies. #919

hdevalence opened this issue Aug 18, 2020 · 1 comment
Labels
A-rust Area: Updates to Rust code E-help-wanted Call for participation: Help is requested to fix this issue. E-needs-test Call for participation: Writing correctness tests

Comments

@hdevalence
Copy link
Contributor

hdevalence commented Aug 18, 2020 •
edited
Loading

As noted in 64d9d55, the existing generate functionality would be better expressed as a collection of proptest strategies, so that it's composable with other test code.

These strategies should be exposed as part of the crate API in test mode, so that they can be used by other crates (particularly zebra_consensus.
@hdevalence hdevalence mentioned this issue Aug 18, 2020
Closed
2 tasks
@dconnolly dconnolly added A-rust Area: Updates to Rust code E-help-wanted Call for participation: Help is requested to fix this issue. E-needs-test Call for participation: Writing correctness tests labels Aug 27, 2020
@teor2345 teor2345 mentioned this issue Sep 7, 2020
Closed
2 tasks
@hdevalence hdevalence mentioned this issue Sep 17, 2020
Closed
12 tasks
@teor2345 teor2345 added this to the Block Validation milestone Sep 29, 2020
@mpguerra mpguerra removed this from the Block Validation milestone Jan 5, 2021
@mpguerra mpguerra mentioned this issue Jan 21, 2022
Closed
51 tasks
@teor2345
Copy link
Contributor

This is not required, and there is a TODO in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rust Area: Updates to Rust code E-help-wanted Call for participation: Help is requested to fix this issue. E-needs-test Call for participation: Writing correctness tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hdevalence @dconnolly @mpguerra @teor2345