Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when trying to post reviews for files that are not present in the compile set #41

Closed
FlorianReimold opened this issue May 20, 2022 · 0 comments · Fixed by #43
Closed

Comments

@FlorianReimold
Copy link
Contributor

FlorianReimold commented May 20, 2022

I haven't fully understood the crash, yet, but I assume it happens when reviewing a file that is not in the compile_commands.json. That can happen e.g. when you have a cross-plattform project where you edited a Windows specific file which is not compiled on Linux. The clang-tidy-review action will compile it anyways and crash.

The file is accessed in the docker container by its relative name (relative to what?):
https://github.com/continental/ecal/runs/6528911109?check_suite_focus=true#step:4:2119

Later it tries to access the name by a non-existing path. For some reason, it misses the workspace directory from the middle of the path.
https://github.com/continental/ecal/runs/6528911109?check_suite_focus=true#step:4:2168

I guess at some point the file list has to be filtered, so only files from the compile_commands.json are checked. I think that behavior should be always acceptable when a compile_commands.json is present.


Edit: My test fork completed its review on the same Windows-specific file and in that PR clang-tidy-review successfully reviewed it. I would still like it to not review that file at all, but at least it didn't mess up the path. Any idea why this happened in the main repo (former 2 links) and how it can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant