drivers: crypto: hash_pkt.in_buf is now constant

Previous commit made the input buffer of the hash packet constant.
Let's therefore adapt typing where used, and remove inappropriate
casts of constant buffers to non-constant ones.

All the "backend" hashing functions already take a constant input,
these changes only affect the "plumbing" between the Zephyr crypto
API and the actual implementation where applicable.

Signed-off-by: Titouan Christophe <titouan.christophe@mind.be>

Author: titouanc

drivers/crypto/crypto_mchp_xec_symcr.c

@@ -358,7 +358,7 @@ static int xec_symcr_do_hash(struct hash_ctx *ctx, struct hash_pkt *pkt, bool fi
 		hs->blklen = 0; /* consumed */
 	}
 
-	ret = mchp_xec_rom_hash_feed_wrapper(c, (const uint8_t *)pkt->in_buf, fill_len);
+	ret = mchp_xec_rom_hash_feed_wrapper(c, pkt->in_buf, fill_len);
 	if (ret) {
 		LOG_ERR("ROM hash feed error %d", ret);
 		return ret;

drivers/crypto/crypto_rts5912_sha.c

@@ -122,7 +122,7 @@ static int rts5912_sha256_process(const struct device *dev, uint8_t *input, size
 	return 0;
 }
 
-static int rts5912_sha256_update(const struct device *dev, uint8_t *input, size_t len)
+static int rts5912_sha256_update(const struct device *dev, const uint8_t *input, size_t len)
 {
 	struct rts5912_sha256_context *rts5912_sha256_ctx = dev->data;
 	uint32_t remain, fill, blk_size = 0, ret_val = 0;

drivers/crypto/crypto_smartbond.c

@@ -390,7 +390,7 @@ static int crypto_smartbond_hash_set_algo(enum hash_algo algo)
 	return 0;
 }
 
-static int crypto_smartbond_set_in_out_buf(uint8_t *in_buf, uint8_t *out_buf, int len)
+static int crypto_smartbond_set_in_out_buf(const uint8_t *in_buf, uint8_t *out_buf, int len)
 {
 	if (in_buf == NULL) {
 		return -EIO;

samples/boards/microchip/mec172xevb_assy6906/rom_api/src/main.c

@@ -441,7 +441,7 @@ static int test_zephyr_hash_chunk_block_size(const struct hash_tp *htbl, size_t
 			/* SHA algorithms block sizes are powers of 2 */
 			updatesz = msgsz & ~(blocksz - 1u);
 			printf("  Update size is %d\n", updatesz);
-			zhash_pkt.in_buf = (uint8_t *)msgptr;
+			zhash_pkt.in_buf = msgptr;
 			zhash_pkt.in_len = updatesz;
 			zhash_pkt.out_buf = digest;
 			zhash_pkt.ctx = &zhash_ctx;
@@ -459,7 +459,7 @@ static int test_zephyr_hash_chunk_block_size(const struct hash_tp *htbl, size_t
 
 		printf("  Final size is %u\n", msgsz);
 
-		zhash_pkt.in_buf = (uint8_t *)msgptr;
+		zhash_pkt.in_buf = msgptr;
 		zhash_pkt.in_len = msgsz;
 		zhash_pkt.out_buf = digest;
 		zhash_pkt.ctx = &zhash_ctx;
@@ -536,7 +536,7 @@ static int test_zephyr_hash_chunk(const struct hash_tp *htbl, size_t nentries, s
 		while (chunksz && ((msgsz - total_updatesz) > chunksz)) {
 			chunk_cnt++;
 
-			zhash_pkt.in_buf = (uint8_t *)msgptr;
+			zhash_pkt.in_buf = msgptr;
 			zhash_pkt.in_len = updatesz;
 			zhash_pkt.out_buf = digest;
 			zhash_pkt.ctx = &zhash_ctx;
@@ -553,7 +553,7 @@ static int test_zephyr_hash_chunk(const struct hash_tp *htbl, size_t nentries, s
 		}
 
 		remsz = msgsz - total_updatesz;
-		zhash_pkt.in_buf = (uint8_t *)msgptr;
+		zhash_pkt.in_buf = msgptr;
 		zhash_pkt.in_len = remsz;
 		zhash_pkt.out_buf = digest;
 		zhash_pkt.ctx = &zhash_ctx;