Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenSSL dependency #274

Closed
nrkramer opened this issue Apr 8, 2023 · 4 comments
Closed

Remove OpenSSL dependency #274

nrkramer opened this issue Apr 8, 2023 · 4 comments
Labels
core something about core enhancement New feature or request Priority:High Priority Label for high priority issue repo something about repo

Comments

@nrkramer
Copy link
Collaborator

nrkramer commented Apr 8, 2023

Please remove the OpenSSL dependency. Tying a dependency as well-known as OpenSSL for networking capabilities (and subsequently needing to ship it with compiled binaries) may set off alarms for users.

If a robust sha algorithm is needed, Hash is a possible alternative.

@ZigRazor
Copy link
Owner

Correct Annotation, it was plan to delete dependencies from external library, that should be precompiled, or installed.

Thank you for the alternative suggested, it could be a good alternative

@ZigRazor ZigRazor added enhancement New feature or request core something about core repo something about repo Priority:High Priority Label for high priority issue labels Apr 11, 2023
@rockingdice
Copy link

No offense, but why should a graph library use OpenSSL? Why involve a network library? I thought it was a purely mathematical problem solver, I'm a bit confused because I found this repo from Google and don't know the details of this library.
Actually, I'm looking for a library that could provide an easy-to-use solution to solve graph problems, I found this library is promising but this issue confuses me.

@nrkramer
Copy link
Collaborator Author

nrkramer commented May 6, 2023

Hey @rockingdice, that's the reason I raised this issue.

I believe OpenSSL is currently being used for its excellent hashing capabilities, which is necessary for making some graph implementations very fast.

@ZigRazor has mentioned it is slated for removal, which should clear this issue up. I've looked at the source code, and no SSL sockets are being opened or used, so the dependency isn't being used in a malicious way - although it makes developing against the library a bit more cumbersome.

Either way, speedy removal seems essential for mass-adoption of this library, as it has incredible promise imo.

@ZigRazor
Copy link
Owner

ZigRazor commented May 7, 2023

This issue was close by the PR #276

@ZigRazor ZigRazor closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core enhancement New feature or request Priority:High Priority Label for high priority issue repo something about repo
Projects
None yet
Development

No branches or pull requests

3 participants