Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zlib dependency #275

Closed
nrkramer opened this issue Apr 8, 2023 · 2 comments · Fixed by #276
Closed

Remove zlib dependency #275

nrkramer opened this issue Apr 8, 2023 · 2 comments · Fixed by #276
Labels
core something about core enhancement New feature or request good first issue Good for newcomers Priority:High Priority Label for high priority issue repo something about repo

Comments

@nrkramer
Copy link
Collaborator

nrkramer commented Apr 8, 2023

A compression library dependency should not be brought into the library if it is only being used for testing.
@ZigRazor
Copy link
Owner

Correct Annotation, it was plan to delete dependencies from external library, that should be precompiled, or installed.

@ZigRazor ZigRazor added enhancement New feature or request good first issue Good for newcomers core something about core repo something about repo Priority:High Priority Label for high priority issue labels Apr 11, 2023
This was referenced May 6, 2023
Closed
Merged
@nrkramer
Copy link
Collaborator Author

nrkramer commented May 6, 2023

Opened #276

@ZigRazor ZigRazor linked a pull request May 7, 2023 that will close this issue
(Issue 209, 275) Make library truly header-only #276
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core something about core enhancement New feature or request good first issue Good for newcomers Priority:High Priority Label for high priority issue repo something about repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Issue 209, 275) Make library truly header-only nrkramer/CXXGraph
2 participants
@nrkramer @ZigRazor