Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch of fixes #1 #122

Open
0xTax opened this issue Aug 20, 2022 · 0 comments · Fixed by #123
Open

Batch of fixes #1 #122

0xTax opened this issue Aug 20, 2022 · 0 comments · Fixed by #123
Assignees

Comments

@0xTax
Copy link

0xTax commented Aug 20, 2022

  • Change the background color to the same as the DEX

  • Overall tidy up the UI, remove unnecessary space/gaps from boxes, make the "swap/deposit/withdraw" bar one with the UI (edges overlap each other), align everything nicely.

  • Move the Mint button to the "swap/deposit/withdraw/Mint" bar (eventually make the button disappear if not on testnet)

  • Fix the connect wallet, approve, swap button not being visible

  • Add insufficient funds button when inserting too much balance (if not already, unable to test because of starknet being down)

  • When wallet is not connected, display connect wallet button instead of preview (deposit / withdraw options)

  • When wallet is not connected, disable slider and % input

  • Deposit preview screen button should be ''Deposit'' instead of ''Invest''

  • Remove max button on proportional deposit, make the highlighted box the same as in withdraw but with no dropdown option, fix displayed amount
    image

  • Copy the highlighted design from DEX convert, similar font and highlight logic too.
    image

image

  • "my pool balance" should show the amount the user owns/has in the pool, not the overall pool stats
  • Nicely space out and tidy deposit & withdraw preview screens
  • "Swap" inputs should start empty and display faded in 0.00
@WonderDev21 WonderDev21 self-assigned this Oct 25, 2022
@WonderDev21 WonderDev21 linked a pull request Oct 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants