Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateTransaction (and probably other ZQ-native APIs) don't perform the same validation checks as ZQ1 #1508

Open
rrw-zilliqa opened this issue Sep 27, 2024 · 0 comments

Comments

@rrw-zilliqa
Copy link
Contributor

In particular, CreateTransaction in Zilliqa 1 checks that the toAddress is correctly checksummed either by Zilliqa or EVM rules. ZQ2 doesn't.

There are probably other instances of this through the API; this has the effect that anyone who is relying on eg. bad addresses being rejected by the API will be disappointed and transactions may be submitted successfully that they weren't expecting, leading to tokens getting lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant