Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eth_feeHistory to support type-2 transactions #1512

Open
yaron-zilliqa opened this issue Sep 30, 2024 · 1 comment
Open

Implement eth_feeHistory to support type-2 transactions #1512

yaron-zilliqa opened this issue Sep 30, 2024 · 1 comment
Labels
Agate Required for mainnet launch

Comments

@yaron-zilliqa
Copy link

When using Alloy to call a function on a contract, we currently have to use a workaround by specifying and empty access list (e.g.:

let call_builder: DynCallBuilder<_, _, _> = contract
            .function("setValidators", &[validators])?
            // FIXME: this is a workaround for using legacy transaction rather than
            //        EIP-1559 ones; without this Alloy will invoke eth_feeHistory
            //        which zq2 doesn't support currently.
            .access_list(AccessList::default());

to force a legacy transaction. Otherwise it will invoke eth_feeHistory which isn't currently supported.

@JamesHinshelwood
Copy link
Contributor

Relates to #1161 (by making EIP-1559 transactions work from alloy)

@DrZoltanFazekas DrZoltanFazekas changed the title Implement eth_feeHistory in zq2 Implement eth_feeHistory to support type-2 transactions Nov 20, 2024
@DrZoltanFazekas DrZoltanFazekas added the Agate Required for mainnet launch label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agate Required for mainnet launch
Projects
None yet
Development

No branches or pull requests

3 participants