Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write or use xyz writer that doesn't affect units #86

Open
Tracked by #5
joshkamm opened this issue Sep 5, 2024 · 0 comments
Open
Tracked by #5

write or use xyz writer that doesn't affect units #86

joshkamm opened this issue Sep 5, 2024 · 0 comments

Comments

@joshkamm
Copy link
Member

joshkamm commented Sep 5, 2024

Once ZimmermanGroup/pyGSM#65 is fixed, update

self.string_energies.append(float(mol_block.split()[0]) / KJ_MOL_TO_AU)
to no longer need a weird unit conversion.
Since we already have results in the old weird units of AU*kcal/kJ, write some sort of logic to differentiate which version of pyGSM the results were generated with and handle the units accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant